Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: do not add removed methods to MessagePort #26109

Closed
wants to merge 1 commit into from
Closed

worker: do not add removed methods to MessagePort #26109

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Do not put the .stop() and .drain() methods on the
MessagePort prototype if we are going to remove them
later on anyway.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
worker: do not add removed methods to MessagePort
0e70a96 
Do not put the `.stop()` and `.drain()` methods on the
`MessagePort` prototype if we are going to remove them
later on anyway.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2607/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Feb 14, 2019
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20789/

@addaleax
Copy link
Member Author

addaleax commented Feb 15, 2019 •
edited
Loading

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20792/ (:heavy_check_mark:)

@addaleax
Copy link
Member Author

Landed in 7f0c515

@addaleax addaleax closed this Feb 17, 2019
@addaleax addaleax deleted the worker-drain-stop branch February 17, 2019 16:43
addaleax added a commit that referenced this pull request Feb 17, 2019
@addaleax
worker: do not add removed methods to MessagePort
7f0c515 
Do not put the `.stop()` and `.drain()` methods on the
`MessagePort` prototype if we are going to remove them
later on anyway.

PR-URL: #26109
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this pull request Feb 17, 2019
@addaleax
worker: do not add removed methods to MessagePort
0f820b8 
Do not put the `.stop()` and `.drain()` methods on the
`MessagePort` prototype if we are going to remove them
later on anyway.

PR-URL: #26109
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@addaleax @rvagg
worker: do not add removed methods to MessagePort
24debc9 
Do not put the `.stop()` and `.drain()` methods on the
`MessagePort` prototype if we are going to remove them
later on anyway.

PR-URL: #26109
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig